generator: make CARGO_MANIFEST_DIR part of ConfigKey#395
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Apr 11, 2025
Merged
generator: make CARGO_MANIFEST_DIR part of ConfigKey#395Kijewski merged 2 commits intoaskama-rs:masterfrom
CARGO_MANIFEST_DIR part of ConfigKey#395Kijewski merged 2 commits intoaskama-rs:masterfrom
Conversation
GuillaumeGomez
approved these changes
Apr 11, 2025
Member
|
Thank you very much for reporting the error, and immediately finding the fix! I added a commit to your PR to move the |
Contributor
Author
|
Great! |
CARGO_MANIFEST_DIR part of ConfigKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust-analyzer appears to share the same
CACHEacross crates in a workspace, causing template path resolution errors.This PR fixes the issue by adding
root(the crate's manifest directory) as a field toConfigKey, ensuring each crate uses its own template cache.