Implement Values on tuple#391
Merged
Kijewski merged 3 commits intoaskama-rs:masterfrom Apr 10, 2025
Merged
Conversation
Kijewski
reviewed
Apr 10, 2025
| `Err(ValueError)`. | ||
| `Err(askama::Error::ValueType)` or a `Err(askama::Error::ValueMissing)`. | ||
|
|
||
| Another example with a tuple: |
Member
There was a problem hiding this comment.
Suggested change
| Another example with a tuple: | |
| Another example with a key-value tuple: |
df7e4a8 to
22011a0
Compare
Kijewski
approved these changes
Apr 10, 2025
Member
|
@GuillaumeGomez, do you want to do a point release? We only merged three PRs compared to the last release, but I don't think we have to wait until it's a big release. And a release every two or three weeks shouldn't cause too much work downstream. |
Collaborator
Author
|
Sure, why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is only one value, using a tuple seems preferrable. I found the need for it in rust-lang/docs.rs#2795. :)