Implement enum variants#255
Merged
GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom Jan 26, 2025
Merged
Conversation
4fe184d to
f62c23a
Compare
Closed
faae42b to
b9f1a5f
Compare
efdb6fc to
06290b4
Compare
a2e9198 to
33afb4c
Compare
a948a9d to
aa66f84
Compare
Collaborator
|
Please tell me when it's ready for final review. ;) (also git conflict) |
548f53d to
61ef8e8
Compare
| ) -> Result<usize, CompileError> { | ||
| let ctx = &contexts[&input.path]; | ||
| if tmpl_kind == TmplKind::Struct { | ||
| buf.write("const _: () = { extern crate rinja as rinja;"); |
Collaborator
There was a problem hiding this comment.
Is the as rinja part useful?
Member
Author
There was a problem hiding this comment.
The same line extern crate rinja as rinja; already exists at other places outside of this PR's changes.
Right now it's a placeholder. I plan to add a crate_ argument to #[template]. That would make it easier to derive Templates in a macro.
Collaborator
|
Apart from the small nits, it looks good to me, great work! Can't wait for this to be merged. :3 |
Member
Author
|
Thank you for the proofreading! Fixed the typos. |
GuillaumeGomez
approved these changes
Jan 26, 2025
Collaborator
|
Thanks for the replies. Still not sure to understand the use case of |
This was referenced Dec 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #223.