Adding support for Gitlab by Prsna23 · Pull Request #149 · ashwanthkumar/gocd-build-github-pull-requests

Prsna23 · 2020-08-16T19:22:09Z

Adding gitlab pr plugin to trigger builds for GitLab merge requests.

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

ashwanthkumar · 2020-08-17T04:52:02Z

src/main/resources/gitlab/plugin.xml

+    <about>
+        <name>Gitlab Pull Requests Builder</name>
+        <version>${version}</version>
+        <target-go-version>15.1.0</target-go-version>


You might want to update this to a more latest version since you're using more latest JDK dependency :)

Sure will update the version.

ashwanthkumar · 2020-08-17T04:52:34Z

src/main/resources/gitlab/plugin.xml

+            <name>Ashwanth Kumar</name>
+            <url>https://github.com/ashwanthkumar/gocd-build-github-pull-requests</url>


Please consider adding your name to this. This is your work and you deserve the credit!

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

ashwanthkumar · 2020-08-17T04:55:08Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

+
+        PullRequestStatus prStatus = null;
+        boolean isDisabled = System.getProperty("go.plugin.gitlab.pr.populate-details", "Y").equals("N");
+        LOG.debug("Populating PR details is disabled");


This log should be inside a if (isDisabled) block isn't?

Yes will change it 👍

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabUtils.java

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

src/test/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabUtilsTest.java

ashwanthkumar · 2020-08-24T06:04:24Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

+                gitConfig.setPassword(props.getProperty(PASSWORD));
+            }
+        } catch (IOException e) {
+            // ignore


Please always throw an exception so it bubbles up on the Server Dashboard with the error Message. Wrap all exceptions inside a RuntimeException.

ashwanthkumar · 2020-08-24T06:05:51Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

+    public void addConfigData(GitConfig gitConfig) {
+        try {
+            Properties props = GitLabUtils.readPropertyFile();
+            if (StringUtil.isEmpty(gitConfig.getUsername())) {
+                gitConfig.setUsername(props.getProperty(LOGIN));
+            }
+            if (StringUtil.isEmpty(gitConfig.getPassword())) {
+                gitConfig.setPassword(props.getProperty(PASSWORD));
+            }


Can you also please update the README with the format of the config file and how to setup the plugin?

ashwanthkumar · 2020-08-24T06:09:02Z

I think apart the above things, we're good to merge this into master and cut a release!

Gitlab4j-api requires jackson version >= 2.9.3. Reference:gitlab4j/gitlab4j-api#184

ashwanthkumar · 2020-08-31T07:46:32Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

            // ignore
            LOG.warn(e.getMessage(), e);
-        } return null;
+            throw new RuntimeException(String.format("Failed to fetch PR status. %s", e.getMessage()), e);


It would be nice to have the log and error have the same message so it is easier to grep on the logs when needed.

ashwanthkumar · 2020-08-31T07:46:45Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

-            loginWith(gitConfig).getProjectApi().getProjects();
+            loginWith(gitConfig).getProjectApi().getProject(GHUtils.parseGithubUrl(gitConfig.getEffectiveUrl()));
        } catch (Exception e) {
            throw new RuntimeException(String.format("check connection failed. %s", e.getMessage()), e);


Please consider logging the exception before throwing them.

ashwanthkumar · 2020-08-31T07:46:55Z

src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java

-        } catch (IOException e) {
-            // ignore
+        } catch (Exception e) {
+            throw new RuntimeException(String.format("Adding config data failed. %s", e.getMessage()), e);


Please consider logging the exception before throwing them.

pom.xml

ashwanthkumar

@Prsna23 LGTM. Can I merge these changes and cut out a beta release?

Prsna23 · 2020-09-08T05:15:20Z

Yes please 😃

ashwanthkumar · 2020-09-08T05:15:37Z

We might need some changes on https://github.com/ashwanthkumar/gocd-build-github-pull-requests/blob/master/release.sh. Not a blocker, I can also do these changes as part of merging it to master. Just putting it out there.

Prsna23 · 2020-09-08T05:18:13Z

I think I have edited the release.sh file as well. Is there something else that needs to be done?

ashwanthkumar · 2020-09-08T05:24:10Z

Ah, I missed that somehow. Thanks. Merging it now.

Prsna23 added 2 commits August 17, 2020 00:50

Adding support for Gitlab

707f7c1

Minor cosmetic change

3362848

ashwanthkumar reviewed Aug 17, 2020

View reviewed changes

Adding PR review changes

5f58f6f

ashwanthkumar reviewed Aug 21, 2020

View reviewed changes

Prsna23 added 2 commits August 21, 2020 23:04

Removed unwanted url parser method

0bf8f4b

Added exception for missing credentials

68d7e02

ashwanthkumar reviewed Aug 24, 2020

View reviewed changes

Prsna23 added 2 commits August 31, 2020 12:34

Fixes SNAKE_CASE error

2ac7cf2

Gitlab4j-api requires jackson version >= 2.9.3. Reference:gitlab4j/gitlab4j-api#184

Replaces oauth2 login with personal access token

b58a811

ashwanthkumar reviewed Aug 31, 2020

View reviewed changes

pom.xml Show resolved Hide resolved

Prsna23 added 2 commits August 31, 2020 14:48

Adds appropriate logs for errors

d69fe4f

Update README with gitlab plugin info

74453bf

ashwanthkumar approved these changes Sep 8, 2020

View reviewed changes

ashwanthkumar merged commit 16dc906 into ashwanthkumar:master Sep 8, 2020

ashwanthkumar mentioned this pull request Sep 22, 2020

Bitbucket PR will not trigger pipeline #139

Open

		<name>Ashwanth Kumar</name>
		<url>https://github.com/ashwanthkumar/gocd-build-github-pull-requests</url>

Uh oh!

Conversation

Prsna23 commented Aug 16, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashwanthkumar commented Aug 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ashwanthkumar left a comment

Choose a reason for hiding this comment

Uh oh!

Prsna23 commented Sep 8, 2020

Uh oh!

ashwanthkumar commented Sep 8, 2020

Uh oh!

Prsna23 commented Sep 8, 2020

Uh oh!

ashwanthkumar commented Sep 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants