Prevent autocomplete on username & password fields#126
Prevent autocomplete on username & password fields#126ashwanthkumar merged 1 commit intoashwanthkumar:masterfrom
Conversation
|
I don't have much experience on working with HTML across browsers. I was just googling about this change, and found the following resources
These sites suggest against using |
|
😢 looks like |
When gocd has authentication enabled, these two fields are auto-populated with the gocd username and password. As a result credentials can be submitted that shouldn't be and a user's gocd account inadvertently compromised. Use the solution as outlined here: https://stackoverflow.com/a/30976223/33226
|
@ashwanthkumar I've updated the pull request with the suggested solution from https://stackoverflow.com/a/30976223/33226. I'll test locally with my users tomorrow and let you know if it's successful or not. The solution only works for Chrome & not Firefox unfortunately. |
|
Tested & confirmed that |
|
👍 Thank you @gavingmiller |
|
I'll cut a release with these changes soon. |
When gocd has authentication enabled, these two fields are auto-populated
with the gocd username and password. As a result credentials can be
submitted that shouldn't be and a user's gocd account inadvertently
compromised.