Conversation
7bd707d to
5fcf4da
Compare
|
winit 0.29 w/ rwh 0.6 is now out. For anybody refreshing this issue, note that winit 0.29 still has a cargo feature for rwh 0.5 support, so this shouldn't block anyone. |
|
yep winit now uses 0.6 |
|
I'm subscribed to the releases after being involved with the |
|
thanks, when do you think would this be pushed? |
|
Any updates on this PR? |
b2b72c9 to
ad553d5
Compare
|
I am open to testing for macos and ios tomorrow. |
|
For what it's worth. This works on Ubuntu 22.04 on my vulkan backend for bevy after updating to bevy 0.13 (which in turn uses the new winit that depends on rwh-0.6). |
|
I must admit my agreeance with the comment from #864 that RWH 0.6 might be overengineering a little, but I will admit a focus on safety is fine. I am using the feature to downgrade to RWH 0.5 on a personal project but would like to +1 this pull request. If there is anything I can do to assist, let me know. |
Ralith
left a comment
There was a problem hiding this comment.
LGTM aside from one nit.
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
…Suspended`/`Resumed` events
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we can even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements:
raw-window-metalvia #8 (Mac/iOS wasn't tested in our CI);ashcrate) to beisizeinstead of*const c_void, matching the usptream definition;winitwithraw-window-handle 0.6becomes available).