Fix selection tool performance in tilemap layers in 'Tiles' mode#5760
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| bool isPixel() override { return true; } | ||
| bool isTile() override { return true; } | ||
|
|
||
| void preparePointShape(ToolLoop* loop) override |
Collaborator
There was a problem hiding this comment.
warning: parameter 'loop' is unused [misc-unused-parameters]
Suggested change
| void preparePointShape(ToolLoop* loop) override | |
| void preparePointShape(ToolLoop* /*loop*/) override |
Member
|
I guess this fixes a performance issue as I noticed a heavy CPU usage without this patch, but I'm not sure if this is related to that (as the PR and the commit don't mention the performance issue). |
Member
|
I've assigned back this PR @Gasparoken so you can improve a little the commit message just to know what this patch does at the user level (not at the internal level) |
Before this fix, large tiles (e.g. 128x128) caused a noticeable delay when releasing the mouse button during a selection action in tilemap mode 'Tiles'. The issue becomes more noticeable with larger tile sizes.
e1a268b to
89d796f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix has no associated issue; the improvement was discovered following the finding that @ckaiser mentioned during a review:
Large tiles (e.g. 128x128) caused a noticeable delay when releasing the mouse button during a selection action in tilemap mode 'Tiles'. The issue becomes more noticeable with larger tile sizes.
How to reproduce the original issue: