UI improvements for layer groups in timeline#5758
Merged
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| false, | ||
| is_hover, | ||
| true); | ||
| drawPart(g, boundsBox, nullptr, bgStyle, false, is_hover, true); |
Collaborator
There was a problem hiding this comment.
warning: repeated branch body in conditional chain [bugprone-branch-clone]
drawPart(g, boundsBox, nullptr, bgStyle, false, is_hover, true);
^Additional context
src/app/ui/timeline/timeline.cpp:2479: end of the original
drawPart(g, boundsBox, nullptr, bgStyle, false, is_hover, true);
^src/app/ui/timeline/timeline.cpp:2481: clone 1 starts here
drawPart(g, boundsBox, nullptr, bgStyle, false, is_hover, true);
^| const int t = std::clamp(thumb_bounds.w / 8, 4, 16); | ||
| draw_checkered_grid(g, thumb_bounds, gfx::Size(t, t), docPref()); | ||
| if (!thumb_bounds.isEmpty()) { | ||
| if (os::SurfaceRef surface = |
Collaborator
There was a problem hiding this comment.
warning: variable 'surface' of type 'os::SurfaceRef' (aka 'Refos::Surface') can be declared 'const' [misc-const-correctness]
Suggested change
| if (os::SurfaceRef surface = | |
| if (os::SurfaceRef const surface = |
5b141d5 to
18708b2
Compare
18708b2 to
48bcd76
Compare
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| while (parent && parent != root) { | ||
| u -= frameBoxWithWithoutZoom; | ||
| gfx::Rect b2(u, textBounds.y, frameBoxWithWithoutZoom, textBounds.h); | ||
| gfx::Rect b3 = b2; |
Collaborator
There was a problem hiding this comment.
warning: variable 'b3' of type 'gfx::Rect' (aka 'RectT') can be declared 'const' [misc-const-correctness]
Suggested change
| gfx::Rect b3 = b2; | |
| gfx::Rect const b3 = b2; |
48bcd76 to
719fda4
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some progress to improve layer groups in timeline (fix #5651)