Allow the CliProcessor to attempt to install extensions (fix #5744)#5748
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
left a comment
There was a problem hiding this comment.
Looks good so far, just a minor change.
As a side note, we could probably include this fix directly to main branch.
| if ( // Check that the filename wasn't used loading a sequence | ||
| // of images as one sprite | ||
| if (ctx->isUIAvailable() && | ||
| base::get_file_extension(cof.filename) == "aseprite-extension") { |
There was a problem hiding this comment.
Probably we could compare with the lower case version of the extension (base::string_to_lower(base::get_file_extension(cof.filename))).
|
Added the lowercase call, I didn't include it on the main branch because Params doesn't have the initializer_list there so when I did the rebase to main it exploded on me😅, I can change it to not use it but I'd rather use the newer constructor |
|
clang-tidy review says "All clean, LGTM! 👍" |
Don't worry, we can integrate this in beta as it is, if everything goes ok, |
Fixes #5744, also useful for portable installs so the user can just drag and drop an extension file onto the executable.