Fix tips for thin filled ellipses#5745
Merged
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Thanks for this patch @emmachase! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I declare that my contributions are not co-authored using a generative AI technology.
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing
Using the filled ellipse tool to draw very tall thin ellipses results in an incorrect & inconsistent result:
Before Fix Video:
Aseprite_hgotk3uAPQ.mp4
After Fix Video (Expected Behavior):
aseprite_Z8MRSQNjHy.mp4
The fix made aligns the
algo_ellipsefillalgorithm with thealgo_ellipsealgorithm, which was correct.