Fix #5545: Update status bar on zoom change#5723
Conversation
|
Hi @Darth712, check that you should have received another email from SignNow to digital sign the CLA. |
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| StatusBar::instance()->updateFromEditor(this); | ||
| } | ||
|
|
||
| void onZoomChanged(Editor* editor) override |
There was a problem hiding this comment.
warning: parameter 'editor' is unused [misc-unused-parameters]
| void onZoomChanged(Editor* editor) override | |
| void onZoomChanged(Editor* /*editor*/) override |
Hi, I just received and signed the CLA |
4c2c797 to
34df6f9
Compare
|
Hi there! One or more of the commit messages in this PR do not match our code submission policy, please check the |
Added an override for the 'onZoomChanged' event in 'doc_view.cpp' to ensure the 'StatusBar' is properly updated whenever the editor's zoom level changes.
34df6f9 to
f8869f9
Compare
|
Hi @dacap It's been a week since the last update. Is there anything else you need from my side? Thanks. |
|
@Darth712 I'll take a look to this PR today and merge it if possible. |
|
Just asking @Darth712, we've received several CLAs from |
|
@dacap I'm doing this as a student for a personal work. |
Thanks for your answer 👍 |
|
Thanks for your fix @Darth712, I've just tested and it works great 👍 |
|
Thank you for the attention @dacap , keep up the great work! |
Cause:
Previously, the StatusBar did not receive a signal when the editor's zoom level was modified, via mouse wheel. This resulted in the zoom percentage displayed in the status bar becoming desynchronized from the actual zoom state.
Fix:
Implemented an override for the "onZoomChanged" function in doc_view.cpp. This ensures that whenever a zoom event is triggered, we check if the editor isActive() and force a StatusBar update via updateFromEditor(this).
I declare that my contributions are not co-authored using a generative AI technology.
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing