Skip to content

Fix hidden layers affect z-index (fix #5681)#5690

Merged
dacap merged 2 commits into
aseprite:betafrom
Gasparoken:fix-z-order
Apr 20, 2026
Merged

Fix hidden layers affect z-index (fix #5681)#5690
dacap merged 2 commits into
aseprite:betafrom
Gasparoken:fix-z-order

Conversation

@Gasparoken

@Gasparoken Gasparoken commented Mar 5, 2026

Copy link
Copy Markdown
Member

fix #5681

@Gasparoken Gasparoken self-assigned this Mar 5, 2026
@Gasparoken Gasparoken requested a review from dacap as a code owner March 5, 2026 16:56
dacap
dacap reviewed Mar 5, 2026
View reviewed changes
Comment thread src/render/render.cpp Outdated
Comment on lines +2 to +3
// Copyright (C) 2019-present Igara Studio S.A.
// Copyright (C) 2001-2018 David Capello

@dacap dacap Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to align these lines.

dacap
dacap reviewed Mar 5, 2026
View reviewed changes
Comment thread src/render/render.cpp Outdated
if (child->isVisible())
subPlan.addLayer(child, frame);
}
for (const Layer* child : static_cast<const LayerGroup*>(layer)->layers())

@dacap dacap Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use

Suggested change
for (const Layer* child : static_cast<const LayerGroup*>(layer)->layers())
for (const Layer* child : layer->layers())

As now (in beta branch) doc::Layer contains the layers().

@dacap

dacap commented Mar 5, 2026

Copy link
Copy Markdown
Member

It's a shame that the RenderPlan includes the hidden layers in the final result. Probably after processing z-indexes we could remove all hidden layers (?).

@aseprite-bot

aseprite-bot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there!

One or more of the commit messages in this PR do not match our code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@aseprite-bot

aseprite-bot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@aseprite-bot

aseprite-bot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@aseprite-bot

aseprite-bot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@Gasparoken Gasparoken assigned dacap and unassigned Gasparoken Mar 6, 2026
@Gasparoken

Gasparoken commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

Test pending

@aseprite-bot

aseprite-bot commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@dacap dacap removed their assignment Mar 10, 2026
@Gasparoken Gasparoken assigned Gasparoken and dacap and unassigned Gasparoken Mar 10, 2026
@Gasparoken

Gasparoken commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@dacap, this PR requires #5692 to run the z_order.lua tests correctly.

@dacap dacap merged commit 48a865a into aseprite:beta Apr 20, 2026
6 of 12 checks passed
@dacap dacap linked an issue Apr 21, 2026 that may be closed by this pull request
Hidden layers affect z-index #5681
Closed
@dacap dacap added this to the v1.3.18-beta2 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dacap dacap dacap left review comments

Assignees

@dacap dacap

Labels

None yet

Projects

None yet

Milestone

v1.3.18-beta2

Development

Successfully merging this pull request may close these issues.

Hidden layers affect z-index

3 participants

@Gasparoken @dacap @aseprite-bot