Fix 'Insert Text' doesn't paste text on viewport's center (fix #5615)#5645
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
The fix works great 👍 but the pre-commit action failed, the patch needs some formatting. |
cbc7619 to
d1624d9
Compare
…te#5615) Old Edit > Insert Text option doesn't paste the text in the center of the viewport. Regression merged on commit 366751d "Command refresh and refactor, ui availability consistency (fix aseprite#3025)"
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
gadahl
reviewed
Mar 8, 2026
There was a problem hiding this comment.
Edit: never mind me, I was looking at an old version of this PR for some reason
Putting the changes all on one line should let it pass the formatting test:
Editor::activeEditor()->pasteImage(image.get(), nullptr, (params().x.isSet() || params().y.isSet()) ? &point : nullptr);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5615