Check if extension files are present to avoid crashes & issues#5593
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
2baa7b7 to
c3d9870
Compare
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
The fix works great! 👍 thanks for the example test extension file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having an installed extension that refers to a non-existing keys file can cause aseprite to crash on load, as
AppMenuattempts to load the XML file without checking if it exists. Other non-existing files can also cause annoying issues (like language entries appearing but doing nothing, etc).This adds some checks to avoid this. The only only necessary one is the
KeyboardShortcutsone, but I think the others won't hurt and make sense.Test exception to reproduce it: test-extension.zip