[lua] Improve Dialog labels and buddy enabled handling (fix #5117) #5554
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
e5eb1bc to
fa6dc0f
Compare
aseprite-bot
reviewed
Dec 5, 2025
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
fa6dc0f to
ad863d4
Compare
Member
|
LGTM 👍 As we talked I'll try to investigate a way to reduce the obs::signal size or create a new lightweight signal for these cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5117, and makes some changes to default behaviors.
Marking as draft because of
Widgetchanges, decided to go for the "simple but disruptive" approach of just adding a new signal to Widget and modifying the defaultonEnabled, it's definitely the simplest approach but it does have ripple effects on the entire app.Decided to leave the "buddy enabled sync" feature disabled by default behind a flag, but we could easily just simplify it and make this the default behavior and void having an extra bool - in fact I think that's probably the way to go before the merge, but I figured I'd first validate this is what we want without any side-effects.
Added the
placeholderandlabelalignpropertes toDialog_add_widget, the former is self-explanatory, the latter is because I noticed all of the labels were aligned to the top-right and it looks kinda bad, but maybe some things rely on the old behavior so I changed the default toui::LEFT | ui::CENTERand added a way to change the alignment if desired to go back to the previous default or any other.Here's a little test script: