Add ignore empty frames toggle to Export As window#5491
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| return forTwitter()->isSelected(); | ||
| } | ||
|
|
||
| bool ExportFileWindow::isIgnoreEmpty() const |
Collaborator
There was a problem hiding this comment.
warning: method 'isIgnoreEmpty' can be made static [readability-convert-member-functions-to-static]
Suggested change
| bool ExportFileWindow::isIgnoreEmpty() const | |
| bool ExportFileWindow::isIgnoreEmpty() |
src/app/ui/export_file_window.h:37:
- bool isIgnoreEmpty() const;
+ static bool isIgnoreEmpty() ;
dacap
requested changes
Oct 27, 2025
dacap
left a comment
Member
There was a problem hiding this comment.
Thanks @JoshuaL03, it looks like save-as CLI tests are broken with this change: https://github.com/aseprite/aseprite/actions/runs/18825250787/job/53706833646#step:11:138
Check my comment below 👇
| doc::AniDir aniDirValue = params().aniDir(); | ||
| bool isPlaySubtags = params().playSubtags(); | ||
| bool isForTwitter = false; | ||
| bool isIgnoreEmpty = false; |
Member
There was a problem hiding this comment.
We need to use the original ignoreEmpty parameter so running from CLI (and CLI tests) work:
Suggested change
| bool isIgnoreEmpty = false; | |
| bool isIgnoreEmpty = params().ignoreEmpty(); |
Contributor
Author
There was a problem hiding this comment.
Updated, thank you for the help!
31361dd to
3a689a8
Compare
Member
|
Thanks @JoshuaL03 👍 just merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature #5452.
This PR adds a toggle to ignore empty frames when using the "Export As..." window. Enabling the setting will prevent all empty frames from being saved/exported.