Fix rotate command creating copy of selection#5461
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
It works great @JoshuaL03, thanks for this patch. Yeah, it looks like the Ctrl key was creating the copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1330.
This PR fixes an issue where using a keyboard shortcut to rotate a selection would create a copy of the selection if certain keys were used. Copies are now only made if a handle is passed to the related code (i.e. rotation was performed through the GUI).