New image iterators#5404
Merged
Merged
Conversation
We can set DOC_USE_BITMAP_AS_1BPP=0 to use 8bpp to simplify iteration of bitmap pixel format using a 8bpp buffer just like indexed mode.
aseprite-bot
reviewed
Sep 1, 2025
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
c7205a5 to
ace9558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some old experiments to add new kind of image iterators (ReadIterator/WriteIterator) and for future plans to change the internal Image representation (#2174). Check the changes in
image_tests.cppandimage_benchmark.cppfor details.