Add "Run Command" window#5393
Conversation
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
ac4ea05 to
5d9fb36
Compare
|
Added fuzzy string matching, we now check for duplicates and commands with @dacap AFAIK there's no way to check if a command is functions like a "toggle", you can call isChecked to know if it's checked, but there's nothing you can call to see if we should show an empty checkbox or maybe do the toggle inside the runner without leaving, might be worth seeing if we wanna add something like
|
|
This looks great 🚀
Nice!
We could change the Some notes:
|
2651a64 to
cf3f061
Compare
cf3f061 to
a5b8097
Compare
|
Adjusted things to avoid listing commands that need parameters to function (added a few missing
Personally I like it better with the prefix because it clearly delineates things as separate "mode", like the Lua expression editor and more importantly makes the code simpler and more readable IMO, it's already a bit complicated as it is. We're also already doing a bunch of things on every |
|
I think it's working great 👍 we can merge it as it is (you can move this to "ready for review") and I'll merge it just in case something is missing. After this is merged I'll make some little changes to the window title bar to reduce a little the translation/i18n work. |
|
Great! I've marked it ready for review and I'll get to writing the documentation so the "?" button doesn't link to a 404 page |



Adds a command runner/"command palette" with the following features:
Commands, including variations with parameters declared as keyboard shortcuts.An (outdated now) video showcase of everything it has to offer:
runner_demo.mp4
Some things needed in order to finish this:
Decide on the shortcut, right now it's Ctrl+Shift+RCtrl+Space