Skip to content

[lua] Refresh timeline when changing layer collapsed status (fix #5366)#5367

Merged
dacap merged 1 commit into
aseprite:mainfrom
ckaiser:timeline-refresh
Aug 26, 2025
Merged

[lua] Refresh timeline when changing layer collapsed status (fix #5366)#5367
dacap merged 1 commit into
aseprite:mainfrom
ckaiser:timeline-refresh

Conversation

@ckaiser

@ckaiser ckaiser commented Aug 19, 2025

Copy link
Copy Markdown
Member

Fixes #5366, had to add a function to force the relayouting of rows, unclear if there's a way to do this through more "proper" event stuff but this seems logical.

@ckaiser ckaiser requested a review from dacap as a code owner August 19, 2025 16:27
@aseprite-bot

Copy link
Copy Markdown
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@dacap

dacap commented Aug 26, 2025

Copy link
Copy Markdown
Member

LGTM 👍 Probably regenerateCols(); is not necessary and doing just the same as Timeline::onLayerCollapsedChanged() is enough, I'll fix this with another commit.

In a future we have to improve the timeline rows generation (to group several operations in one).

@dacap dacap merged commit 8e75cfc into aseprite:main Aug 26, 2025
12 checks passed
@dacap dacap added this to the v1.3.15 milestone Aug 26, 2025
@ckaiser ckaiser deleted the timeline-refresh branch September 10, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layer.isCollapsed/isExpanded do not update Timeline visuals

3 participants