Use the CLI paste when incoming masks have no bitmap (fix #5361)#5363
Closed
ckaiser wants to merge 1 commit into
Closed
Use the CLI paste when incoming masks have no bitmap (fix #5361)#5363ckaiser wants to merge 1 commit into
ckaiser wants to merge 1 commit into
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
I was testing this and it shows the following error after running the script in the given issue in an empty sprite (a new sprite with transparent background): Or in debug just pasting a native bitmap (copying the image from other program) on a sprite with a background layer: 
If you ignore the assert, the image is pasted but without interactivity, and after undoing, Aseprite crashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5361, switches over to "CLI" pasting when the incoming mask has no bitmap, since that can cause problems with the interactive selection, I think this is cleaner than my previous attempt to prevent this kind of thing from getting into the clipboard in the first place, this way things can get pasted "properly" even if they're just a blank image with no selection.