Fix Color Management regression (fix #5333)#5357
Merged
Merged
Conversation
Before this fix, the assigned color space was always sRGB (default), so this color space was used for the rest of the rendering. Now the color space for the back layer of the display has been made explicit.
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
I'll be doing a bit more research because there may still be similar bugs in other makeSurface() calls. However, the current PR, which would be the most critical fix, may be merged asap. |
Member
|
Should we merge this PR as it is? |
Member
Author
Yes. Just to let you know that this PR is half the solution. I discovered there's another part of the code that also converts the color space to sRGB (I'm still looking). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5333