Implement Label buddies#5356
Merged
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
requested changes
Sep 4, 2025
dacap
left a comment
Member
There was a problem hiding this comment.
Looks great so far! Some minor changes are required 👍
be8beb5 to
f494b8f
Compare
aseprite-bot
reviewed
Sep 6, 2025
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| class FocusMessage : public Message { | ||
| public: | ||
| FocusMessage(MessageType type, Widget* oldFocus, Widget* newFocus) | ||
| enum class Source { |
Collaborator
There was a problem hiding this comment.
warning: enum 'Source' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum class Source {
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Label "buddies", so that clicking on a label that's attached to another widget will focus said widget, similar to the HTML
forproperty.The PR adds the implementation and also adds one to every label that benefits from it, this required minor changes in some places (adding
setIdcalls when there were placeholder widgets and adjusting some hierarchies so the buddy was easy to find withfindChild, which also simplifies markup).Examples:
Recording.2025-08-15.060335.mp4