Allow typing numbers into Slider widgets#5355
Merged
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
requested changes
Sep 1, 2025
dacap
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 Minor change to use base::tick_t instead of base::Chrono.
773ebd2 to
a84c5e7
Compare
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability for the user to use the number keys change the value of slider widgets, including negative numbers. Pressing backspace also deletes a number like in a text input, serves as both a power user feature and an accessibility one, for fine grained control and keyboard navigation.
Recording.2025-08-15.053617.mp4
(I should've recorded this with some kind of input overlay, hopefully it's understandable enough)