Allow gif encoding to be stopped (fix #2619)#5320
Merged
Merged
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
reviewed
Aug 4, 2025
| for (gifframe_t gifFrame = 0; gifFrame < nframes; ++gifFrame) { | ||
| ASSERT(frame_it != frame_end); | ||
| if (m_fop->isStop()) | ||
| break; |
Member
Author
There was a problem hiding this comment.
This way you end up with a valid GIF, even if it doesn't have the full frames. Better than a broken file IMO since we're already past the point where it's started writing to disk.
Member
There was a problem hiding this comment.
Oh it's fine in this way, other encoders do the same, and the issue is handled later checking if the operation was canceled so the sprite is marked as "modified", so the user has a second chance to save the file later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2619, here's a test file with a lot of frames to try it: f500.zip