Fix thumbnails for macOS Sequoia (fix #5009)#5314
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
left a comment
There was a problem hiding this comment.
Looks great! 👍 Some minor changes can be made to create bin/Aseprite.app properly (instead of bin/aseprite.app) and see if the .appex can go directly to the PlugIns directory.
| main.mm | ||
| set(extension_target AsepriteThumbnailer) | ||
|
|
||
| add_executable(${extension_target} MACOSX_BUNDLE |
There was a problem hiding this comment.
Could we just output the .appex inside the bin/Aseprite.app/Contents/PlugIns directory? Not sure if it does make sense (or if it simplify the build scripts later).
| if(ENABLE_ASEPRITE_EXE) | ||
| set(main_target aseprite) | ||
| if(APPLE) | ||
| set(DATA_OUTPUT_DIR ${CMAKE_BINARY_DIR}/bin/${main_target}.app/Contents/Resources/data) |
There was a problem hiding this comment.
There is an issue here where the output directory should be Aseprite.app (not aseprite.app):
| set(DATA_OUTPUT_DIR ${CMAKE_BINARY_DIR}/bin/${main_target}.app/Contents/Resources/data) | |
| set(DATA_OUTPUT_DIR ${CMAKE_BINARY_DIR}/bin/Aseprite.app/Contents/Resources/data) |
|
|
||
| add_library(AsepriteThumbnailer SHARED | ||
| main.mm | ||
| set(extension_target AsepriteThumbnailer) |
There was a problem hiding this comment.
Probably we keep the AsepriteThumbnailer name (without incorporating the extension_target variable).
| set(DATA_OUTPUT_DIR ${CMAKE_BINARY_DIR}/bin/data) | ||
|
|
||
| if(ENABLE_ASEPRITE_EXE) | ||
| set(main_target aseprite) |
There was a problem hiding this comment.
Same here, probably we can just remove the main_target var (introduced in 11e4243 but not sure why, probably just for "searchability" purposes).
|
@Gasparoken I can take this PR and finish the distribution process if you cannot continue with this one. |
|
@dacap, yes of course. Go ahead. Thank you! |
…mbnailing framework QUICKLOOK_LIBRARY might be cached to QuickLook.framework giving some compilation errors: #5314 (comment)
Last minimalist macos 10.15 thumbnail integretaion.
This PR includes the fix for image alpha premultiplication. Additionally, AsepriteThumbnailer.appex is now a package without dependency of aseprite.app
fix #5009
This PR replaces #5293