Skip to content

[lua] Add onchecked parameter to Commands#5310

Merged
dacap merged 1 commit into
aseprite:mainfrom
ckaiser:command-onchecked
Aug 7, 2025
Merged

[lua] Add onchecked parameter to Commands#5310
dacap merged 1 commit into
aseprite:mainfrom
ckaiser:command-onchecked

Conversation

@ckaiser

@ckaiser ckaiser commented Jul 31, 2025

Copy link
Copy Markdown
Member

Implements #5198

Adds a new onchecked property for plugin commands, to make menus such as this possible:

Screenshot 2025-07-31 014139

Test extension: menuonchecked

@ckaiser ckaiser requested a review from dacap as a code owner July 31, 2025 04:49

@aseprite-bot aseprite-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/app/script/plugin_class.cpp
Comment thread src/app/script/plugin_class.cpp
Comment thread src/app/script/plugin_class.cpp
Comment thread src/app/script/plugin_class.cpp
Comment thread src/app/script/plugin_class.cpp
@dacap dacap assigned martincapello and unassigned dacap Aug 6, 2025

@martincapello martincapello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 👏

@martincapello martincapello assigned dacap and unassigned martincapello Aug 7, 2025
@dacap dacap merged commit 229a3cd into aseprite:main Aug 7, 2025
12 checks passed
@dacap dacap added this to the v1.3.15 milestone Aug 26, 2025
@dacap dacap linked an issue Aug 26, 2025 that may be closed by this pull request
@ckaiser ckaiser deleted the command-onchecked branch September 10, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add plugin:NewCheckCommand() to the API

4 participants