[win] Fix ResourceFinder::includeDesktopDir returning the default path#5304
Merged
Conversation
Uses SHGFP_TYPE_CURRENT which returns the Desktop that the user has configured instead of the default, fixes Windows 11's OneDrive Desktop folder.
Collaborator
|
Hi there! One or more of the commit messages in this PR do not match our code submission policy, please check the |
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
LGTM 👍 this function is used for the debug .txt file and for screenshots (ScreenshotCommand), and it looks like it matches the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5302
Uses
SHGFP_TYPE_CURRENTwhich returns the Desktop that the user has configured instead of the default. Fixes Windows 11's OneDrive-by-default Desktop folder and any customizable/moved Desktop in general. Have not tested on Windows versions below 11 but we're still using the old API so it shouldn't really change anything.