One way to do this would be adding something like app.getLastCommandError() or something like that, that we could populate after every execution? Maybe with some common error codes or strings, that way scripts could communicate in their own way what errors they stumble into.

Actually Command_call should return false if the command fails (an exception is thrown).

Anyway there is not too much information about the error, and for regular errors (non-exceptional, like the UI is not available) we could try to create a new method to return command results (probably related to #3952).

I'd leave this error handling for the future (not in this PR).

Did the changes, I'm also gonna see about documenting the fact that we reuse instances because it can definitely be a gotcha for script authors as well.

Actually Command_call should return false if the command fails (an exception is thrown).

An exception yes, but the command being disabled still returns true when the command hasn't been run, which I think we should change especially now that it's more consistently indicating stuff.

Edit: Added CommandResult::kDisabled and in testing it seems to work well for this kind of thing, let me know what you think!

I'm also gonna see about documenting the fact that we reuse instances because it can definitely be a gotcha for script authors as well.

I think this internal detail shouldn't be documented in the API. Shouldn't affect the behavior of scripts, at least commands should behave like an action in itself that doesn't depend on previous calls of the same command.

An exception yes, but the command being disabled still returns true when the command hasn't been run, which I think we should change especially now that it's more consistently indicating stuff.

Edit: Added CommandResult::kDisabled and in testing it seems to work well for this kind of thing, let me know what you think!

Yeah, we can add a new kind of result code 👍 Anyway we might need some way to check if the command is enabled before executing it, e.g.:

if app.command.SaveFile.enabled then
  ...
end

Added the .enabled property and added some more isUIEnabled checks.

Edit: Looking into the test failures.

Added parameters for PasteTextCommand, this involved basically writing a different version that didn't use Editor::pasteImage, so an extra set of eyes on the implementation is appreciated since pixel pushing is not my forte (yet?)