Fix crash dropping file on timeline#5295
Conversation
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
63991e4 to
1e55667
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
LGTM, just tested it and the fix works! 👍 The only thing we could try to improve is |
1e55667 to
1856ab9
Compare
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| layer->displaceFrames(fromThis, delta); | ||
| } | ||
|
|
||
| layer_t LayerGroup::getLayerIndex(const Layer* layer, layer_t& index) const |
There was a problem hiding this comment.
warning: function 'getLayerIndex' is within a recursive call chain [misc-no-recursion]
layer_t LayerGroup::getLayerIndex(const Layer* layer, layer_t& index) const
^Additional context
src/doc/layer.cpp:599: example recursive call chain, starting from function 'getLayerIndex'
layer_t LayerGroup::getLayerIndex(const Layer* layer, layer_t& index) const
^src/doc/layer.cpp:602: Frame #1: function 'getLayerIndex' calls function 'getLayerIndex' here:
if ((child->isGroup() && static_cast<LayerGroup*>(child)->getLayerIndex(layer, index) != -1) ||
^src/doc/layer.cpp:602: ... which was the starting point of the recursive call chain; there may be other cycles
if ((child->isGroup() && static_cast<LayerGroup*>(child)->getLayerIndex(layer, index) != -1) ||
^
Fix #5289