Prioritize mouse wheel zooming with quick zoom tool#5118
Merged
Conversation
Member
|
Thanks @hwabis 👍 we're going to include this fix in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing
Fixes #2019
Before this PR: scrolling with "Zoom Tool (quick)" held down works if you assign it to a keyboard shortcut that's not used by anything else (e.g. "7"). However, scrolling if it's assigned to something like "Ctrl+Space" does not work, I think because this was line eating it:
aseprite/src/app/ui/editor/state_with_wheel_behavior.cpp
Lines 98 to 101 in b3f4e37