fix: properly pass missing env vars in Plugin.Update#1899
Closed
n-rodriguez wants to merge 1 commit intoasdf-vm:masterfrom
n-rodriguez:fix/missing_env_vars
Closed
fix: properly pass missing env vars in Plugin.Update#1899n-rodriguez wants to merge 1 commit intoasdf-vm:masterfrom n-rodriguez:fix/missing_env_vars
n-rodriguez wants to merge 1 commit intoasdf-vm:masterfrom
n-rodriguez:fix/missing_env_vars
Conversation
Stratus3D
reviewed
Feb 8, 2025
internal/plugins/plugins.go
Outdated
|
|
||
| env := map[string]string{ | ||
| "HOME": os.Getenv("HOME"), | ||
| "ASDF_DIR": os.Getenv("ASDF_DIR"), |
Member
There was a problem hiding this comment.
ASDF_DIR isn't something that is used in asdf 0.16.0+. Are there still plugins relying on this?
Contributor
Author
There was a problem hiding this comment.
Are there still plugins relying on this?
Contributor
There was a problem hiding this comment.
Is there a reason why we shouldn't propagate all env variables of the current process by default here (similar to #1958 )?
Stratus3D
reviewed
Feb 19, 2025
Member
Stratus3D
left a comment
There was a problem hiding this comment.
I think if plugin callbacks need arbitrary environment variables I think we should pass-through any environment variable that is already set. Like we do for shims when executing the real executable.
Contributor
Author
|
Closed in favor of #1982 |
Member
|
Replaced by #1982 |
Contributor
Author
|
@Stratus3D Closed in favor of #1982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Properly pass missing env vars in Plugin.Update
Fixes:
Thank you!