test: extract shared RTL patterns for artwork filter specs #13052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed91e2f to
ce57784
Compare
anandaroop
commented
Oct 20, 2023
Member
Author
There was a problem hiding this comment.
Decided to keep these helpers in src/Components/ArtworkFilter instead of src/DevTools because if its limited applicability to just this part of the codebase.
Comment on lines
-18
to
-19
| // FIXME: SWC_COMPILER_MIGRATION | ||
| it.skip("updates context on filter change", () => { |
Member
Author
There was a problem hiding this comment.
Looks like these specs were skipped in this commit — but I found that they were green and ran in tens of milliseconds, so seems fine to un-pend this. cc @damassi
anandaroop
commented
Oct 20, 2023
Comment on lines
+13
to
+15
| /** | ||
| * A test helper that can be used to render components that depend | ||
| * on an enclosing `ArtworkFilterContext`. |
Member
Author
There was a problem hiding this comment.
Tried to get some good intellisense going…
Member
Author
|
Going for it, so I can keep #13041 moving… |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Test
Decided to split this from #13041 (comment) so that I can get this on
mainand then include it in that PR.Description
This takes some patterns for working with artwork filters in a react-testing-library friendly way and extracts them into shared helpers.
This was introduced in the original RTL spike for the
SizeFilterspec, copied over to theKeywordFilterspec and now will be used for theArtistSeriesFilterspec as well.Seems like a good time to extract and document this shareable code.