Prepend '::' to Twirp::Service and Twirp::Client to prevent namespace collisions#77
Prepend '::' to Twirp::Service and Twirp::Client to prevent namespace collisions#77wmatveyenko merged 1 commit intoarthurnn:mainfrom Grayscale-Labs:fix-namespacing
Conversation
|
workaround, for anyone who stumbles on this: |
|
Hi. Thanks for your contribution. Can you add some tests that catch this error? Also, please add a comment with "By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license." |
Updated the PR description w/ that comment. Hmm, would that be a go test since it's testing the code-generation? (TBH my golang-fu is not very strong 😬) But -- this change is so simple that as long as existing tests still pass, it should be acceptable IMO. Here is all that prefixing with |
|
(Also thx for taking a look!) |
|
Thanks for the explanation. |
I ran into this issue when I structured my protobufs in such a way that the resulting ruby file ended up like...
which causes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.