Skip to content

Convert to Go modules and retract v7.1.2#72

Merged
mellis merged 1 commit intoarthurnn:mainfrom
mellis:retract
Sep 20, 2021
Merged

Convert to Go modules and retract v7.1.2#72
mellis merged 1 commit intoarthurnn:mainfrom
mellis:retract

Conversation

@mellis
Copy link
Contributor

@mellis mellis commented Sep 20, 2021

I converted the Go portion of this repository to modules and retracted the previously incorrectly published version v7.1.2+incompatible

I did this by running the following

go mod init github.com/twitchtv/twirp-ruby
go mod tidy
go mod edit -retract "v7.1.2+incompatible"
go mod vendor
go mod tidy

Then verified with

go test ./...
go install ./...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

marioizquierdo
marioizquierdo approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@marioizquierdo marioizquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much 🙏

@mellis mellis merged commit a1a8eb9 into arthurnn:main Sep 20, 2021
@mellis mellis deleted the retract branch September 20, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioizquierdo marioizquierdo marioizquierdo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mellis @marioizquierdo