Rewind rack input when reading the request#65
Merged
marioizquierdo merged 1 commit intomasterfrom Apr 23, 2021
Merged
Conversation
ajvondrak
approved these changes
Apr 18, 2021
ajvondrak
left a comment
There was a problem hiding this comment.
LGTM. If you wanted to add some tests, you could make a Rack middleware that tries to read the body downstream from the Twirp::Service (which would've blown up before). This behavior is emulated in some tests I wrote here, but those involve Rails so I'm afraid it's kind of hard to tease apart the relevant pieces. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #50