Add option to enable strict mode for JSON Client.#63
Merged
marioizquierdo merged 2 commits intoarthurnn:masterfrom Nov 24, 2020
Merged
Add option to enable strict mode for JSON Client.#63marioizquierdo merged 2 commits intoarthurnn:masterfrom
marioizquierdo merged 2 commits intoarthurnn:masterfrom
Conversation
A PR added a while back to add a strict JSON vs non-strict JSON mode. This adds a flag to JSON client to enable strict mode which can be useful when doing testing.
marioizquierdo
approved these changes
Nov 24, 2020
Collaborator
marioizquierdo
left a comment
There was a problem hiding this comment.
Absolutely.
It makes sense, because ClientJSON is meant for manual debugging (vs Client.new(conn, content_type: "application/json") that is meant for usage in production).
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR a while back added strict JSON vs non-strict JSON encoding.
This adds a flag to JSON client to enable that strict mode which can be
useful when doing testing.