Use ldflags, not lddlflags, in direct library test#129
Closed
alyssais wants to merge 1 commit intoarsv:masterfrom
Closed
Use ldflags, not lddlflags, in direct library test#129alyssais wants to merge 1 commit intoarsv:masterfrom
alyssais wants to merge 1 commit intoarsv:masterfrom
Conversation
With a compiler that can only produce static executables, the previous test would fail because e.g. -shared would end up getting passed here. I've tested various cross-compilations with this change, both dynamic and static.
13 tasks
Owner
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a compiler that can only produce static executables, the previous test would fail because e.g. -shared would end up getting passed here.
I've tested various cross-compilations with this change, both dynamic and static.