Skip to content

Work around frozen progress dialog#694

Merged
arsenetar merged 2 commits into
arsenetar:masterfrom
glubsy:fix_matchblock_freeze
Jul 28, 2020
Merged

Work around frozen progress dialog#694
arsenetar merged 2 commits into
arsenetar:masterfrom
glubsy:fix_matchblock_freeze

Conversation

@glubsy

@glubsy glubsy commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

See bug #693

  • It seems that matchblock.getmatches() returns too early and the (multi-)processes become zombies.
  • This is a workaround which seems to work by sleeping for one second and avoid zombie processes.

* It seems that matchblock.getmatches() returns too early and the (multi-)processes become zombies
* This is a workaround which seems to work by sleeping for one second and avoid zombie processes
@glubsy

glubsy commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

I came up with this workaround after adding a breakpoint on the "return result" statement at the end of the matchblock.getmaches() function avoided the deadlock every time, so I'm suspecting some sort of race condition or something here.

@arsenetar

Copy link
Copy Markdown
Owner

Took a quick look at the documentation for multiprocessing, if I understand the join() method (https://docs.python.org/3.8/library/multiprocessing.html#multiprocessing.pool.Pool.join) then perhaps including that instead of the sleep might fix this as well?

@glubsy

glubsy commented Jul 28, 2020

Copy link
Copy Markdown
Contributor Author

You are right, thanks. It seems to work just fine now.

@arsenetar arsenetar merged commit d2235f9 into arsenetar:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants