Colorize details table differences, allow moving around of rows#682
Merged
Conversation
* Replaces the "Attribute" column with a horizontal header * We ignore the first value in each row from the model and instead populate a horizontal header with the value in order to allow
* Could be better optimized if there is a way to set those variables earlier in the model or somewhere in the viewer when it requests the data. * Right now it compares strings(?) many times for every role we handle, which is not ideal.
Owner
|
Most of this looks good, there are a few flake8 errors to correct, you can see them in the Travis run. |
Contributor
Author
|
My bad, should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ignore the "Dupe count" row since it's not very useful to highlight
We also Ignore fields when they hold blank values "---" (when only one dupe is selected and displayed)
Note: this is performing string comparison for each role requested by the view. Couldn't find a more optimized way of doing this.
Perhaps it would be good to add more customization options for the user later.
Another improvement would be to highlight only the part of a path that differs, but so far I have no idea how to efficiently do that. Might require to do changes to the underlying model.