Skip to content

Add shortcut description to mark selected action#656

Merged
arsenetar merged 2 commits into
arsenetar:masterfrom
glubsy:selected_shortcut_description
May 14, 2020
Merged

Add shortcut description to mark selected action#656
arsenetar merged 2 commits into
arsenetar:masterfrom
glubsy:selected_shortcut_description

Conversation

@glubsy

@glubsy glubsy commented May 7, 2020

Copy link
Copy Markdown
Contributor

As per #641 add missing shortcut description to the mark selected action.
Technically this is not the description but an actual shortcut (setup by createActions(), and according to PyQt5 documentation SetShortcut() can take a string).
However, the spacePressed event is what is actually called, so either the QAction's shortcut doesn't really work here, or they are both called (which doesn't seem likely since marking seems to work just fine still).

@glubsy

glubsy commented May 7, 2020

Copy link
Copy Markdown
Contributor Author

There is a problem, the translation doesn't work in this case.

@glubsy glubsy closed this May 7, 2020
@glubsy glubsy reopened this May 7, 2020
@glubsy

glubsy commented May 7, 2020

Copy link
Copy Markdown
Contributor Author

For now let's use QKeySequence, we'll worry about translations a bit later (will have to update them too).

@arsenetar arsenetar merged commit 6abcedd into arsenetar:master May 14, 2020
@David-FullStop

Copy link
Copy Markdown

dupeGuru is a remarkable program.

It works today May 20, 2020 wonderfully in WIndows 10.

SAD and IRONIC, this excellent (once linux) program NO LONGER functions under Ubuntu 20.04.

@glubsy

glubsy commented May 20, 2020

Copy link
Copy Markdown
Contributor Author

@David-FullStop what does this have to do with this pull request exactly? What is not working in Ubuntu? Please create a new issue and report the details.

@David-FullStop

David-FullStop commented May 21, 2020 via email

Copy link
Copy Markdown

@arsenetar

Copy link
Copy Markdown
Owner

@David-FullStop I do appreciate the feedback. Packaging and testing on Linux is an area of this project, which is currently lacking manpower (thus why a ~30 day old release of Ubuntu still has issues). In order for issues like this to have better visibility, it is normally best to submit a new issue or find an existing issue which represents your issue like #484, #620, or #637.

You will be pleased to know that there is an open pull request (#665), which aims to help resolve one of the existing issues with Ubuntu 20.04.

Repository owner locked as off-topic and limited conversation to collaborators May 21, 2020
@glubsy glubsy deleted the selected_shortcut_description branch June 10, 2020 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants