Broadside: Correct Postgres ingestion ordering and nil safety#4736
Merged
mauriceyap merged 1 commit intomasterfrom Mar 3, 2026
Merged
Broadside: Correct Postgres ingestion ordering and nil safety#4736mauriceyap merged 1 commit intomasterfrom
mauriceyap merged 1 commit intomasterfrom
Conversation
Replace the parallel COPY-based ExecuteIngestionQueryBatch with explicit sequential phases matching the production Lookout ingester: job rows are committed before job runs are inserted, and inserts complete before updates. Conflation (last-write-wins per job/run ID) is applied in queriesToInstructionSet before the instructions reach the database. Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
eleanorpratt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the parallel COPY-based ExecuteIngestionQueryBatch with explicit sequential phases matching the production Lookout ingester: job rows are committed before job runs are inserted, and inserts complete before updates.