Fix bug with checking if node is overallocated#4727
Merged
JamesMurkin merged 2 commits intomasterfrom Mar 2, 2026
Merged
Conversation
A recent PR fixed MarkResourceUnallocatable - https://github.com/armadaproject/armada/pull/4714/changes#diff-1586be9e6d66471f316b4f536803e03351ba2b47132b9e34d0b6d4332101e5c2R859 However that inadvertently caused another bug where the resource is removed before we check if the node is overallocated The upshot of this is we consider a node overallocated when it isn't. Due to marking resource unallocatable before comparing it to what is allocated - Resulting in allocated > allocatable and deeming it overallocated Now we check if a node is overallocated before we mark any resource unallocatable - resulting in the expected behaviour Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
mauriceyap
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent PR fixed MarkResourceUnallocatable
However that inadvertently caused another bug where the resource is removed before we check if the node is overallocated
The upshot of this is we consider a node overallocated when it isn't. Due to marking resource unallocatable before comparing it to what is allocated
Now we check if a node is overallocated before we mark any resource unallocatable - resulting in the expected behaviour