Make away node types more configurable#4724
Merged
JamesMurkin merged 8 commits intomasterfrom Feb 27, 2026
Merged
Conversation
An away node type is now: - Made up of a list of well known node types - Each well known node type can also have conditions that must be met for it to take effect This allows us to add gpu node taints to cpu jobs conditionally but not inadvertently add all gpu node taints to gpu jobs Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
dejanzele
reviewed
Feb 27, 2026
| jobResources: testfixtures.Cpu("2"), | ||
| expectMatch: false, | ||
| }, | ||
| // Missing resource treated as zero |
Member
There was a problem hiding this comment.
redundant comment as the test case name mentions the same
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com> # Conflicts: # internal/scheduler/configuration/configuration.go
dejanzele
approved these changes
Feb 27, 2026
MustafaI
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An away node type is now:
This allows us to add gpu node taints to cpu jobs conditionally but not inadvertently add all gpu node taints to gpu jobs