Fix issues in pod issue detection#4703
Merged
JamesMurkin merged 2 commits intomasterfrom Feb 20, 2026
Merged
Conversation
- Removed the `util.HasCurrentStateBeenReported(pod)` check and now just simply ignore all terminal pods
- Other processes handle terminal pods - leave it to them to handle
- Having `util.HasCurrentStateBeenReported(pod)` just added a race between detecting issues / reporting state
- Made it so we don't handle pods stuck in terminal state IF the executor was the one that called delete
- Cluster context will handle this issue itself as it was the one to call delete, so leave it to that to handle
- Making the issue handle tell the cluster context about this potential issue
- This is so if the executor restarts, the pod being stuck will still get handled
- We don't need to send events about it, as the executor already was trying to delete it
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
mauriceyap
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util.HasCurrentStateBeenReported(pod)check and now just simply ignore all terminal podsutil.HasCurrentStateBeenReported(pod)just added a race between detecting issues / reporting state