Remove only-new-issues from lint check#4700
Merged
JamesMurkin merged 2 commits intomasterfrom Feb 18, 2026
Merged
Conversation
This flag attempts to run the linting only on changes - which in theory works if master is fully linted However in practice this often misses issues resulting in master not working - We only discover this at release time (not even master build) which means we have to make further fixes + releases This is the simplest fix - it just removes the bit trying to be "smart" and just ensures the whole code base is linted - if this is fast enough we should just do this - Based on release lints, the different is minimal If this isn't fast enough we can look what we can do to make this catch issues in PRs while still being an acceptable speed
mauriceyap
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag attempts to run the linting only on changes - which in theory works if master is fully linted
However in practice this often misses issues resulting in master not working
This is the simplest fix - it just removes the bit trying to be "smart" and just ensures the whole code base is linted - if this is fast enough we should just do this
If this isn't fast enough we can look what we can do to make this catch issues in PRs while still being an acceptable speed