Merged
Conversation
Contributor
kiranchandramohan
left a comment
There was a problem hiding this comment.
Looks good. A few nits, if I understood correctly the syntax.
| [A clear and concise description of what the bug is] | ||
|
|
||
| **To Reproduce** | ||
| 1. [Steps to reproduce] |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. [Steps to reproduce] | |
| [Steps to reproduce] |
Contributor
Author
There was a problem hiding this comment.
I wanted to suggest providing steps as a numbered list, if it makes sense.
| **[Risks]** | ||
| [Optional: Consider risks and mitigations, if relevant] | ||
|
|
||
| **Alternatives** |
Contributor
There was a problem hiding this comment.
Suggested change
| **Alternatives** | |
| **[Alternatives]** |
Contributor
Author
There was a problem hiding this comment.
Sorry, should be other way around: "Optional" removed from the description.
Contributor
Author
There was a problem hiding this comment.
Fixed by removing "Optional"
| [A clear and concise description of any alternative solutions or features you've considered] | ||
|
|
||
| **Additional context** | ||
| Add any other context or screenshots about the feature request here. |
Contributor
There was a problem hiding this comment.
Suggested change
| Add any other context or screenshots about the feature request here. | |
| [Add any other context or screenshots about the feature request here.] |
pratlucas
reviewed
Apr 30, 2025
| [A clear and concise description of any alternative solutions or features you've considered] | ||
|
|
||
| **Additional context** | ||
| Add any other context or screenshots about the feature request here. |
Contributor
There was a problem hiding this comment.
Nit: Missing surrounding [].
pratlucas
reviewed
Apr 30, 2025
.github/ISSUE_TEMPLATE/rfc.md
Outdated
| [Optional: Highlight why the proposal makes sense, especially if this is not a problem solving, but exploiting an opportunity] | ||
|
|
||
| **[Implementation or Transition]** | ||
| [Optional: Some solutions many need multiple steps to be implemented or require migration/transition period from the previous approach - outline the plan here] |
Contributor
There was a problem hiding this comment.
Typo: many -> may
Suggested change
| [Optional: Some solutions many need multiple steps to be implemented or require migration/transition period from the previous approach - outline the plan here] | |
| [Optional: Some solutions may need multiple steps to be implemented or require a migration/transition period from the previous approach - outline the plan here] |
Change-Id: I87705dc1bbcc8c60384539184f5a28b91d282095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.