[ATfE] Add required strictly aligned variants for Armv8.1-M Main#298
Merged
vhscampos merged 1 commit intoarm:arm-softwarefrom Apr 25, 2025
Merged
[ATfE] Add required strictly aligned variants for Armv8.1-M Main#298vhscampos merged 1 commit intoarm:arm-softwarefrom
vhscampos merged 1 commit intoarm:arm-softwarefrom
Conversation
Two non-PACBTI variants needed a strictly aligned counterpart: - armv8.1m.main_hard_nofp_mve - armv8.1m.main_hard_nofp_mve_exn_rtti because no suitable Armv7-M variant exists for these two as a fallback option. The combination of hard FP ABI and no FPU is not covered by our Armv7-M variants. On the PACBTI side, all the existing variants needed their strictly aligned counterparts. This is because it's not safe to fallback to Armv7-M variants in this case, as these are not built for PACBTI. This patch introduces new strictly aligned variants for Armv8.1-M Main. Two of them are for non-PACBTI + hard FP ABI + no FPU, while the rest is for all the PACBTI variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two non-PACBTI variants needed a strictly aligned counterpart:
because no suitable Armv7-M variant exists for these two as a fallback option. The combination of hard FP ABI and no FPU is not covered by our Armv7-M variants.
On the PACBTI side, all the existing variants needed their strictly aligned counterparts. This is because it's not safe to fallback to Armv7-M variants in this case, as these are not built for PACBTI.
This patch introduces new strictly aligned variants for Armv8.1-M Main. Two of them are for non-PACBTI + hard FP ABI + no FPU, while the rest is for all the PACBTI variants.