Fix shell quoting in embedded/scripts directory.#277
Merged
statham-arm merged 1 commit intoarm:arm-softwarefrom Apr 15, 2025
Merged
Fix shell quoting in embedded/scripts directory.#277statham-arm merged 1 commit intoarm:arm-softwarefrom
statham-arm merged 1 commit intoarm:arm-softwarefrom
Conversation
While reviewing arm#270 I noticed some missing quotes in the new script, and David spotted that that's because they're the same in all the other similar scripts. Fix the whole lot. Building in a spacey directory might fail anyway (quite likely _something_ in the overall build edifice isn't prepared to cope). But we can at least fix the issues we find.
dcandler
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #270 I noticed some missing quotes in the new script, and David spotted that that's because they're the same in all the other similar scripts. Fix the whole lot.
Building in a spacey directory might fail anyway (quite likely something in the overall build edifice isn't prepared to cope). But we can at least fix the issues we find.