This repository was archived by the owner on May 30, 2023. It is now read-only.
Closed
Conversation
Contributor
Author
Contributor
|
@eugene1g Nice work 🤘 Maybe worth applying the upstream patch exactly as-is? |
Contributor
Author
|
Good idea. I just updated the patch to be exactly as it is upstream, and verified by recompiling on 10.10 - the binary still works as expected. |
Contributor
|
👍 |
Owner
|
Looks good. I suggest squashing this into just one commit. Give me a few days to get access to Yosemite and verify the fix. |
Contributor
Author
|
Squashed! |
|
Whats going on with this? It's been open a while. |
Owner
|
Landed on the master branch and will be backported to 2.0 branch. Thanks @eugene1g! |
|
+1 |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick&dirty QT to allow building on Yosemite / XCode6 as per Homebrew/legacy-homebrew#29837 (comment)
This has been patched upstream with https://qt.gitorious.org/qt/qtbase/commit/70e4428b6f1c6a4bad112203f67ee7d22107616c so if Phantom QT fork will be updated then this patch will be obsolete.